Первая версия решений by Ivan-Voronyuk · Pull Request #24 · DafeCpp/spring_alogorithms

Ivan-Voronyuk · 2025-06-23T03:13:08Z

8 задач
К сожалению, в некоторых местах могут быть неаккуратные названия функций/переменных.

Solution to 8 tasks. Some code lacks formatting. Will probably be fixed in future versions.

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 15 out of 28. Check the log or trigger a new build to see more.

github-actions · 2025-06-23T03:16:08Z

+#include "solution.hpp"
+
+int main() {
+  std::cout << (BinarySearchGEQ({1, 2, 3, 4, 5}, 1, 0, 4) == 0) << std::endl;


warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]

Suggested change

std::cout << (BinarySearchGEQ({1, 2, 3, 4, 5}, 1, 0, 4) == 0) << std::endl;

std::cout << (BinarySearchGEQ({1, 2, 3, 4, 5}, 1, 0, 4) == 0) << '\n';

github-actions · 2025-06-23T03:16:09Z

+int main() {
+  std::cout << (BinarySearchGEQ({1, 2, 3, 4, 5}, 1, 0, 4) == 0) << std::endl;
+  std::cout << (BinarySearchGEQ({1, 2, 3, 4, 5}, 5, 0, 4) == 4)
+            << std::endl;  // Stack []


warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]

Suggested change

<< std::endl; // Stack []

<< '\n'; // Stack []

github-actions · 2025-06-23T03:16:09Z

+
+  for (unsigned int repeation = 0; repeation < 1000; ++repeation) {
+    constexpr unsigned int N = 1000;
+    std::array<int, N> min;


warning: uninitialized record type: 'min' [cppcoreguidelines-pro-type-member-init]

Suggested change

std::array<int, N> min;

std::array<int, N> min{};

github-actions · 2025-06-23T03:16:09Z

+    ASSERT_EQ(min[0], mstack.GetMin());  // forward pass - zero
+    for (unsigned int i = 1; i < N; ++i) {
+      int value = dist(rng);
+


warning: do not use array subscript when the index is not an integer constant expression [cppcoreguidelines-pro-bounds-constant-array-index]

min[i] = std::min(min[i - 1], value); ^

github-actions · 2025-06-23T03:16:09Z

+    ASSERT_EQ(min[0], mstack.GetMin());  // forward pass - zero
+    for (unsigned int i = 1; i < N; ++i) {
+      int value = dist(rng);
+


warning: do not use array subscript when the index is not an integer constant expression [cppcoreguidelines-pro-bounds-constant-array-index]

min[i] = std::min(min[i - 1], value); ^

github-actions · 2025-06-23T03:16:10Z

+  return heapsort_inplace(arr);
+}
+
+inline void heapify(std::vector<int>& arr, uint I, uint L) {


warning: function 'heapify' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]

Suggested change

inline void heapify(std::vector<int>& arr, uint I, uint L) {

inline static void heapify(std::vector<int>& arr, uint I, uint L) {

github-actions · 2025-06-23T03:16:10Z

+
+inline void heapify(std::vector<int>& arr, uint I, uint L) {
+  uint next = I;
+  do {


warning: avoid do-while loops [cppcoreguidelines-avoid-do-while]

do { ^

github-actions · 2025-06-23T03:16:10Z

+
+    sortings::qsort_inplace(arr);
+
+    int target_res = (1 << std::popcount(i)) - 1;


warning: no member named 'popcount' in namespace 'std'; did you mean '__popcount'? [clang-diagnostic-error]

Suggested change

int target_res = (1 << std::popcount(i)) - 1;

int target_res = (1 << std::__popcount(i)) - 1;

Additional context

/usr/include/c++/13/bit:288: '__popcount' declared here

__popcount(_Tp __x) noexcept ^

github-actions · 2025-06-23T03:16:10Z

+
+    for (uint j = 0; j < 16; ++j) actual_res = (actual_res << 1) | arr[j];
+
+    ASSERT_EQ(std::format("{:016b}", target_res),


warning: no member named 'format' in namespace 'std' [clang-diagnostic-error]

ASSERT_EQ(std::format("{:016b}", target_res), ^

Additional context

/usr/include/gtest/gtest.h:1897: expanded from macro 'ASSERT_EQ'

#define ASSERT_EQ(val1, val2) GTEST_ASSERT_EQ(val1, val2) ^

/usr/include/gtest/gtest.h:1881: expanded from macro 'GTEST_ASSERT_EQ'

ASSERT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^

/usr/include/gtest/gtest_pred_impl.h:147: expanded from macro 'ASSERT_PRED_FORMAT2'

GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_FATAL_FAILURE_) ^

/usr/include/gtest/gtest_pred_impl.h:133: expanded from macro 'GTEST_PRED_FORMAT2_'

GTEST_ASSERT_(pred_format(#v1, #v2, v1, v2), on_failure) ^

/usr/include/gtest/gtest_pred_impl.h:78: expanded from macro 'GTEST_ASSERT_'

if (const ::testing::AssertionResult gtest_ar = (expression)) \ ^

github-actions · 2025-06-23T03:16:10Z

+    for (uint j = 0; j < 16; ++j) actual_res = (actual_res << 1) | arr[j];
+
+    ASSERT_EQ(std::format("{:016b}", target_res),
+              std::format("{:016b}", actual_res))


warning: no member named 'format' in namespace 'std' [clang-diagnostic-error]

std::format("{:016b}", actual_res)) ^

Additional context

/usr/include/gtest/gtest.h:1897: expanded from macro 'ASSERT_EQ'

#define ASSERT_EQ(val1, val2) GTEST_ASSERT_EQ(val1, val2) ^

/usr/include/gtest/gtest.h:1881: expanded from macro 'GTEST_ASSERT_EQ'

ASSERT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^

/usr/include/gtest/gtest_pred_impl.h:147: expanded from macro 'ASSERT_PRED_FORMAT2'

GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_FATAL_FAILURE_) ^

/usr/include/gtest/gtest_pred_impl.h:133: expanded from macro 'GTEST_PRED_FORMAT2_'

GTEST_ASSERT_(pred_format(#v1, #v2, v1, v2), on_failure) ^

/usr/include/gtest/gtest_pred_impl.h:78: expanded from macro 'GTEST_ASSERT_'

if (const ::testing::AssertionResult gtest_ar = (expression)) \ ^

Fixed first task random test fail

github-actions

clang-tidy made some suggestions

github-actions · 2025-06-23T03:44:59Z

+
+    ASSERT_EQ(std::format("{:016b}", target_res),
+              std::format("{:016b}", actual_res))
+        << std::format("sorting failed on binary pattern {} {:016b}", i, i);


warning: no member named 'format' in namespace 'std' [clang-diagnostic-error]

<< std::format("sorting failed on binary pattern {} {:016b}", i, i); ^

github-actions · 2025-06-23T03:45:00Z

+
+    sortings::heapsort_inplace(arr);
+
+    int target_res = (1 << std::popcount(i)) - 1;


warning: no member named 'popcount' in namespace 'std'; did you mean '__popcount'? [clang-diagnostic-error]

Suggested change

int target_res = (1 << std::popcount(i)) - 1;

int target_res = (1 << std::__popcount(i)) - 1;

Additional context

/usr/include/c++/13/bit:288: '__popcount' declared here

__popcount(_Tp __x) noexcept ^

github-actions · 2025-06-23T03:45:00Z

+
+    for (uint j = 0; j < 16; ++j) actual_res = (actual_res << 1) | arr[j];
+
+    ASSERT_EQ(std::format("{:016b}", target_res),


warning: no member named 'format' in namespace 'std' [clang-diagnostic-error]

ASSERT_EQ(std::format("{:016b}", target_res), ^

Additional context

/usr/include/gtest/gtest.h:1897: expanded from macro 'ASSERT_EQ'

#define ASSERT_EQ(val1, val2) GTEST_ASSERT_EQ(val1, val2) ^

/usr/include/gtest/gtest.h:1881: expanded from macro 'GTEST_ASSERT_EQ'

ASSERT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^

/usr/include/gtest/gtest_pred_impl.h:147: expanded from macro 'ASSERT_PRED_FORMAT2'

GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_FATAL_FAILURE_) ^

/usr/include/gtest/gtest_pred_impl.h:133: expanded from macro 'GTEST_PRED_FORMAT2_'

GTEST_ASSERT_(pred_format(#v1, #v2, v1, v2), on_failure) ^

/usr/include/gtest/gtest_pred_impl.h:78: expanded from macro 'GTEST_ASSERT_'

if (const ::testing::AssertionResult gtest_ar = (expression)) \ ^

github-actions · 2025-06-23T03:45:00Z

+    for (uint j = 0; j < 16; ++j) actual_res = (actual_res << 1) | arr[j];
+
+    ASSERT_EQ(std::format("{:016b}", target_res),
+              std::format("{:016b}", actual_res))


warning: no member named 'format' in namespace 'std' [clang-diagnostic-error]

std::format("{:016b}", actual_res)) ^

Additional context

/usr/include/gtest/gtest.h:1897: expanded from macro 'ASSERT_EQ'

#define ASSERT_EQ(val1, val2) GTEST_ASSERT_EQ(val1, val2) ^

/usr/include/gtest/gtest.h:1881: expanded from macro 'GTEST_ASSERT_EQ'

ASSERT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2) ^

/usr/include/gtest/gtest_pred_impl.h:147: expanded from macro 'ASSERT_PRED_FORMAT2'

GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_FATAL_FAILURE_) ^

/usr/include/gtest/gtest_pred_impl.h:133: expanded from macro 'GTEST_PRED_FORMAT2_'

GTEST_ASSERT_(pred_format(#v1, #v2, v1, v2), on_failure) ^

/usr/include/gtest/gtest_pred_impl.h:78: expanded from macro 'GTEST_ASSERT_'

if (const ::testing::AssertionResult gtest_ar = (expression)) \ ^

github-actions · 2025-06-23T03:45:00Z

+
+    ASSERT_EQ(std::format("{:016b}", target_res),
+              std::format("{:016b}", actual_res))
+        << std::format("sorting failed on binary pattern {} {:016b}", i, i);


warning: no member named 'format' in namespace 'std' [clang-diagnostic-error]

<< std::format("sorting failed on binary pattern {} {:016b}", i, i); ^

github-actions · 2025-06-23T03:45:00Z

+  auto [L, R] = root->Split(key);
+  return {SplayTree(L), SplayTree(R)};
+}
+void SplayTree::Merge(SplayTree&& other) {


warning: rvalue reference parameter 'other' is never moved from inside the function body [cppcoreguidelines-rvalue-reference-param-not-moved]

void SplayTree::Merge(SplayTree&& other) { ^

github-actions · 2025-06-23T03:45:00Z

+
+class SplayTree {
+ private:
+  class SplayTreeNode {


warning: constructor does not initialize these fields: key, value [cppcoreguidelines-pro-type-member-init]

task_07/src/tree.hpp:9:

- int key; - int value; + int key{}; + int value{};

github-actions · 2025-06-23T03:45:01Z

+ public:
+  SplayTree() = default;
+  SplayTree(SplayTree const& other) = delete;
+  SplayTree(SplayTree&& old);


warning: move constructors should be marked noexcept [cppcoreguidelines-noexcept-move-operations]

Suggested change

SplayTree(SplayTree&& old);

SplayTree(SplayTree&& old) noexcept ;

github-actions · 2025-06-23T03:45:01Z

+  int size;
+  int cap;
+  int scale;
+  const int step_a = 25;


warning: member 'step_a' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]

const int step_a = 25; ^

github-actions · 2025-06-23T03:45:01Z

+  int scale;
+  const int step_a = 25;
+  int step_b;
+  const int default_value;


warning: member 'default_value' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]

const int default_value; ^

Solution first version

c874493

Solution to 8 tasks. Some code lacks formatting. Will probably be fixed in future versions.

github-actions Bot reviewed Jun 23, 2025

View reviewed changes

Fixed first task

43f4ab9

Fixed first task random test fail

github-actions Bot reviewed Jun 23, 2025

View reviewed changes

	std::cout << (BinarySearchGEQ({1, 2, 3, 4, 5}, 1, 0, 4) == 0) << std::endl;
	std::cout << (BinarySearchGEQ({1, 2, 3, 4, 5}, 1, 0, 4) == 0) << '\n';

	inline void heapify(std::vector<int>& arr, uint I, uint L) {
	inline static void heapify(std::vector<int>& arr, uint I, uint L) {


		sortings::qsort_inplace(arr);

		int target_res = (1 << std::popcount(i)) - 1;

	int target_res = (1 << std::popcount(i)) - 1;
	int target_res = (1 << std::__popcount(i)) - 1;


		for (uint j = 0; j < 16; ++j) actual_res = (actual_res << 1) \| arr[j];

		ASSERT_EQ(std::format("{:016b}", target_res),


		sortings::heapsort_inplace(arr);

		int target_res = (1 << std::popcount(i)) - 1;

	SplayTree(SplayTree&& old);
	SplayTree(SplayTree&& old) noexcept ;

Conversation

Ivan-Voronyuk commented Jun 23, 2025

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant